Fix realloc mistake: ptr nulled but not freed upon failure

2019-03-24 22:09:25 +01:00
parent 44c3a0a8aa
commit 19588b045f
1 changed files with 5 additions and 2 deletions
--- a/client/cmdflashmem.c
+++ b/client/cmdflashmem.c
@@ -260,9 +260,12 @@ int CmdFlashMemLoad(const char *Cmd) {
            break;
    }

-    data = realloc(data, datalen);
-    if (!data) {
+    uint8_t *newdata = realloc(data, datalen);
+    if (newdata == NULL) {
+        free(data);
        return 1;
+    } else {
+        data = newdata;
    }

    //Send to device