dash/blackcoin-more
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
10,262 Commits 4 Branches 0 Tags
77d8ddc6fb6b68db24dc14df2fef9b5ba41bb77f
Commit Graph

10262 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pieter Wuille
77d8ddc6fb Stop treating importaddress'ed scripts as change 
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.

Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
 2018-01-08 21:48:12 +03:00
Pedro Branco
8e2f81bb7f Prevent multiple calls to ExtractDestination 2018-01-08 21:47:33 +03:00
Jonas Schnelli
22bebdaacd [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds 2018-01-08 21:46:56 +03:00
MarcoFalke
2b9c31046b [wallet] rpc: Drop misleading option in importprunedfunds 2018-01-08 21:45:39 +03:00
instagibbs
8bca020397 Added companion removeprunedfunds call. 2018-01-08 21:36:30 +03:00
instagibbs
c37ac7db87 Add importprunedfunds rpc call 2018-01-08 21:36:08 +03:00
Patrick Strateman
db3b5d964a Move BackupWallet to CWallet::BackupWallet 2018-01-08 21:31:59 +03:00
lateminer
261efcf69a Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into wallet-updates-0.13 2018-01-08 19:45:45 +03:00
janko33bd
26cbe6bc72 Merge pull request #16 from lateminer/wallet-mod 
[Wallet] refactor wallet/init interaction
 2018-01-07 21:02:54 +01:00
janko33bd
518e327e7c Merge pull request #14 from lateminer/rpc-updates-0.13 
RPC updates from Bitcoin Core 0.13.x
 2018-01-07 21:02:38 +01:00
lateminer
af7f906c74 Remove unused constants 2018-01-07 15:52:28 +03:00
lateminer
b808896d4c [Wallet] refactor wallet/init interaction 
25340b7cd5
 2018-01-07 15:29:36 +03:00
Jonas Schnelli
aefae306e5 [Wallet] Bugfix: FRT: don't terminate when keypool is empty 2018-01-07 13:45:21 +03:00
Gregory Maxwell
c1a0128033 Make RelayWalletTransaction attempt to AcceptToMemoryPool. 2018-01-07 13:44:47 +03:00
crowning-
40ebee8dec CDB: fix debug output 
It doesn't really help to clear a variable before printing it to the debug log.
 2018-01-07 13:38:33 +03:00
Jonas Schnelli
ea219cd59d [Wallet] Trivial cleanup of HD wallet changes 2018-01-07 13:37:11 +03:00
Wladimir J. van der Laan
77ea5eb519 wallet: Revert input selection post-pruning 
This reverts PR #4906, "Coinselection prunes extraneous inputs from
ApproximateBestSubset".

Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.

See also #7664, #7657, as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
 2018-01-07 13:36:04 +03:00
Patrick Strateman
e94e583f48 Improve CWallet API with new GetAccountPubkey function. 
Remove one more caller that is passing CWalletDB.
 2018-01-07 13:33:46 +03:00
Patrick Strateman
acf8c3d9ce Improve CWallet API with new AccountMove function. 2018-01-07 13:33:24 +03:00
Pieter Wuille
4db9e14749 Don't use assert for catching randomness failures 2018-01-07 13:28:01 +03:00
Pieter Wuille
f9d2d353ff Always require OS randomness when generating secret keys 2018-01-07 13:27:51 +03:00
Patrick Strateman
ee0b4321ff Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance 2018-01-07 13:22:45 +03:00
João Barbosa
26f8d58b92 Fix lockunspents help message 2018-01-07 13:16:18 +03:00
João Barbosa
395af2c291 Prevent multiple calls to CWallet::AvailableCoins 2018-01-07 13:15:46 +03:00
Alex Morcos
db8b7554fd Don't resend wallet txs that aren't in our own mempool 2018-01-07 13:11:12 +03:00
Wladimir J. van der Laan
289e2f80b4 wallet: Warn on unexpected EOF while salvaging wallet 
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.

Stricter error checking could shed more light on issues such as #7463
and #7379.
 2018-01-07 12:57:13 +03:00
Chris Moore
412c8b9946 Reduce inefficiency of GetAccountAddress() 
Don't scan the wallet to see if the current key has been used if we're going to make a new key anyway.
Stop scanning the wallet as soon as we see that the current key has been used.
Don't call isValid() twice on the current key.
 2018-01-07 12:56:47 +03:00
janko33bd
de1a0db4cf Merge pull request #15 from lateminer/show-password 
[ui] Add toggle for unblinding password fields
 2018-01-07 00:00:07 +01:00
Thomas Snider
3b0604b58d [ui] Add toggle for unblinding password fields 2018-01-07 01:18:20 +03:00
lateminer
b4b34ff770 Get rid of remaining auto_ptr mentions 2018-01-06 16:44:09 +03:00
lateminer
99238ff2c8 Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into rpc-updates-0.13 2018-01-06 16:41:28 +03:00
Jonas Schnelli
5deab0d5fa [Wallet] Bugfix: FRT: don't terminate when keypool is empty 
Github-Pull: #9295
Rebased-From: c24a4f5981d47d55aa9e4eb40294832a4d38fb80
 2018-01-06 15:33:50 +03:00
MarcoFalke
20a60575fb [qa] Add getinfo smoke tests and rework versionbits test 2018-01-06 15:26:07 +03:00
MarcoFalke
5c6c445cf4 [rpc] Deprecate getinfo 2018-01-06 15:23:24 +03:00
MarcoFalke
2ddde6bf92 [rpc] ParseHash: Fail when length is not 64 2018-01-06 15:05:09 +03:00
Masahiko Hyuga
e403754e15 fix getnettotals RPC description about timemillis. 2018-01-06 15:04:25 +03:00
matthias
106dc385ee Change all instance of 'GMT epoch' to 'Unix epoch' 2018-01-06 15:04:03 +03:00
jnewbery
7307b5f5a1 Don't return the address of a P2SH of a P2SH. 2018-01-06 15:01:34 +03:00
Wladimir J. van der Laan
bf9cd01f5c rpc: Generate auth cookie in hex instead of base64 
Base64 contains '/', and the '/' character in credentials is problematic
for AuthServiceProxy which represents the RPC endpoint as an URI with
user and password embedded.

Closes #8399.
 2018-01-06 14:51:14 +03:00
Luke Dashjr
8d0a8afe73 Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block 2018-01-06 14:50:55 +03:00
Jonas Schnelli
621f5f19d9 [RPC] Fix createrawtx sequence number unsigned int parsing 2018-01-06 14:43:52 +03:00
Suhas Daftuar
bc7d750fd6 Refactor logic for converting mempool entries to JSON 2018-01-06 14:42:30 +03:00
MarcoFalke
9067422492 [rpc] fundrawtransaction feeRate: Use BTC/kB 
Also introduce UniValueType

UniValueType is a wrapper for UniValue::VType which allows setting
a typeAny flag. This flag indicates the type does not matter.

(Used by RPCTypeCheckObj)
 2018-01-06 14:41:03 +03:00
MarcoFalke
ac8653f486 [rpc] fundrawtransaction: Fix help text and interface 2018-01-06 14:40:55 +03:00
Jonas Schnelli
893db80a40 [Bitcoin-Tx] Add tests for sequence number support 2018-01-06 14:38:26 +03:00
Jonas Schnelli
6b045bd557 [bitcoin-tx] allow to set nSequence number over the in= command 2018-01-06 14:38:18 +03:00
Jonas Schnelli
3756163ce0 [RPC] createrawtransaction: add option to set the sequence number per input 2018-01-06 14:38:11 +03:00
Jonas Schnelli
3674e65b54 Add more clear interface for CoinControl.h regarding individual feerate 2018-01-06 14:37:42 +03:00
Jonas Schnelli
4aab709412 [RPC] add feerate option to fundrawtransaction 2018-01-06 14:37:33 +03:00
Andrew Chow
547dada2d4 Test for signing messages 2018-01-06 14:36:56 +03:00