From b91bc9bb856e9895dd2c3c10bd5fa92bf6a83030 Mon Sep 17 00:00:00 2001 From: tcprst Date: Wed, 23 Dec 2020 16:01:50 -0500 Subject: [PATCH 1/3] hf_legic Lua - change method for temp file naming --- client/luascripts/hf_legic.lua | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/client/luascripts/hf_legic.lua b/client/luascripts/hf_legic.lua index b8b9931cd..ca06ae8c5 100644 --- a/client/luascripts/hf_legic.lua +++ b/client/luascripts/hf_legic.lua @@ -704,12 +704,31 @@ function writeFile(bytes, filename) return true end +function getRandomTempName() + local upperCase = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" + local lowerCase = "abcdefghijklmnopqrstuvwxyz" + + local characterSet = upperCase .. lowerCase + + local keyLength = 8 + local output = "" + + for i = 1, keyLength do + local rand = math.random(#characterSet) + output = output .. string.sub(characterSet, rand, rand) + end + + output = "hf-legic-temp-" .. output + + return output +end + --- -- read from pm3 into virtual-tag function readFromPM3() local tag, bytes, infile --infile="legic.temp" - infile=os.tmpname() + infile=getRandomTempName() core.console("hf legic dump -f "..infile) tag=readFile(infile..".bin") os.remove(infile) From 902b6c98668e894901995f5e9de76969943f48c5 Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Wed, 23 Dec 2020 22:54:56 +0100 Subject: [PATCH 2/3] hf/lf tune - show Volt max. And use corect session support identification --- client/src/ui.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/src/ui.c b/client/src/ui.c index 25d5edf7e..885910919 100644 --- a/client/src/ui.c +++ b/client/src/ui.c @@ -657,7 +657,8 @@ void print_progress(size_t count, uint64_t max, barMode_t style) { "\xe2\x96\x88", }; - uint8_t mode = session.emoji_mode == EMOJI; + uint8_t mode = session.supports_colors; + const char *block[] = {"#", "\xe2\x96\x88"}; // use a 3-byte space in emoji mode to ease computations const char *space[] = {" ", "\xe2\x80\x80"}; @@ -704,12 +705,12 @@ void print_progress(size_t count, uint64_t max, barMode_t style) { break; } case STYLE_MIXED: { - sprintf(buffer, "%s [ %zu mV / %3u V ]", cbar, count, (uint32_t)(count / 1000)); + sprintf(buffer, "%s [ %zu mV / %2u V / %2u Vmax ]", cbar, count, (uint32_t)(count / 1000), (uint32_t)(max / 1000)); printf("\b%c[2K\r[" _YELLOW_("=")"] %s ", 27, buffer); break; } case STYLE_VALUE: { - printf("[" _YELLOW_("=")"] %zu mV / %3u V \r", count, (uint32_t)(count / 1000)); + printf("[" _YELLOW_("=")"] %zu mV / %2u V / %2u Vmax\r", count, (uint32_t)(count / 1000), (uint32_t)(max / 1000)); break; } } From 3d76be2dbdcfa7bc293ba06614b7acd6a451cccb Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Thu, 24 Dec 2020 10:55:36 +0100 Subject: [PATCH 3/3] coverity fix --- client/src/cmdhf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/src/cmdhf.c b/client/src/cmdhf.c index ada69e905..85044f27b 100644 --- a/client/src/cmdhf.c +++ b/client/src/cmdhf.c @@ -52,13 +52,15 @@ int CmdHFSearch(const char *Cmd) { CLIParserInit(&ctx, "hf search", "Will try to find a HF read out of the unknown tag.\n" "Continues to search for all different HF protocols.", - "hf sniff" + "hf search" ); void *argtable[] = { arg_param_begin, arg_param_end }; CLIExecWithReturn(ctx, Cmd, argtable, true); + CLIParserFree(ctx); + int res = PM3_ESOFT; PROMPT_CLEARLINE;