dash/proxmark3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIX: Coverity scan fixes, hard to keep track of stringlengths while reading and copying in C.

Browse Source
This commit is contained in:
iceman1001
2016-02-17 10:46:08 +01:00
parent 82885445b3
commit aacb96d7ed
6 changed files with 60 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
client/nonce2key/crapto1.c
View File

@@ -486,12 +486,11 @@ struct Crypto1State* lfsr_common_prefix(uint32_t pfx, uint32_t rr, uint8_t ks[8]
odd = lfsr_prefix_ks(ks, 1);
even = lfsr_prefix_ks(ks, 0);
s = statelist = malloc((sizeof *statelist) << 21);
s = statelist = malloc((sizeof *statelist) << 20);
if(!s || !odd || !even) {
free(statelist);
free(odd);
free(even);
return 0;
statelist = 0;
goto out;
}
for(o = odd; *o + 1; ++o)
@@ -503,8 +502,8 @@ struct Crypto1State* lfsr_common_prefix(uint32_t pfx, uint32_t rr, uint8_t ks[8]
}
s->odd = s->even = 0;
out:
free(odd);
free(even);
return statelist;
}
}

4
client/nonce2key/crypto1.c
View File

@@ -24,7 +24,9 @@ struct Crypto1State * crypto1_create(uint64_t key)
{
struct Crypto1State *s = malloc(sizeof(*s));
if ( !s ) return NULL;
s->odd = s->even = 0;
int i;
//for(i = 47;s && i > 0; i -= 2) {
for(i = 47; i > 0; i -= 2) {