good const, bad const, fixing -Wincompatible-pointer-types-discards-qualifiers

This commit is contained in:
Philippe Teuwen
2019-04-10 10:21:42 +02:00
parent e703dcb8ad
commit 7f76fea21a
45 changed files with 124 additions and 124 deletions

View File

@@ -142,7 +142,7 @@ void reverse_arraycopy(uint8_t *arr, uint8_t *dest, size_t len) {
}
}
void printarr(char *name, uint8_t *arr, int len) {
void printarr(const char *name, uint8_t *arr, int len) {
int cx, i;
size_t outsize = 40 + strlen(name) + len * 5;
char *output = calloc(outsize, sizeof(char));
@@ -155,7 +155,7 @@ void printarr(char *name, uint8_t *arr, int len) {
free(output);
}
void printvar(char *name, uint8_t *arr, int len) {
void printvar(const char *name, uint8_t *arr, int len) {
int cx, i;
size_t outsize = 40 + strlen(name) + len * 2;
char *output = calloc(outsize, sizeof(char));
@@ -168,7 +168,7 @@ void printvar(char *name, uint8_t *arr, int len) {
free(output);
}
void printarr_human_readable(char *title, uint8_t *arr, int len) {
void printarr_human_readable(const char *title, uint8_t *arr, int len) {
int cx, i;
size_t outsize = 100 + strlen(title) + len * 4;
char *output = calloc(outsize, sizeof(char));

View File

@@ -69,7 +69,7 @@ uint64_t x_bytes_to_num(uint8_t *src, size_t len);
uint8_t reversebytes(uint8_t b);
void reverse_arraybytes(uint8_t *arr, size_t len);
void reverse_arraycopy(uint8_t *arr, uint8_t *dest, size_t len);
void printarr(char *name, uint8_t *arr, int len);
void printvar(char *name, uint8_t *arr, int len);
void printarr_human_readable(char *title, uint8_t *arr, int len);
void printarr(const char *name, uint8_t *arr, int len);
void printvar(const char *name, uint8_t *arr, int len);
void printarr_human_readable(const char *title, uint8_t *arr, int len);
#endif // CIPHERUTILS_H

View File

@@ -221,7 +221,7 @@ void printbegin() {
PrintAndLogDevice(NORMAL, " | x| y|z0|z1|z2|z3|z4|z5|z6|z7|");
}
void printState(char *desc, uint64_t c) {
void printState(const char *desc, uint64_t c) {
if (debug_print < 2)
return;
@@ -569,7 +569,7 @@ int testKeyDiversificationWithMasterkeyTestcases() {
return error;
}
void print64bits(char *name, uint64_t val) {
void print64bits(const char *name, uint64_t val) {
printf("%s%08x%08x\n", name, (uint32_t)(val >> 32), (uint32_t)(val & 0xFFFFFFFF));
}