dash/blackcoin-more
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
10,750 Commits 4 Branches 0 Tags
e5dba2d2934b8fe3b8cf2d49a89ad586ca8b9d0b
Commit Graph

273 Commits

Author SHA1 Message Date
lateminer
765380cf35 Revert "Make RelayWalletTransaction attempt to AcceptToMemoryPool." 
This reverts commit c1a0128033.
 2018-01-08 22:35:33 +03:00
Cory Fields
d4b0ab2149 crypter: constify encrypt/decrypt 
This makes CCrypter easier to pass aroundf for tests
 2018-01-08 21:59:36 +03:00
Cory Fields
b1913e4dd2 crypter: add tests for crypter 2018-01-08 21:59:28 +03:00
Cory Fields
df2b01b7cd crypter: add a BytesToKey clone to replace the use of openssl 
BytesToKeySHA512AES should be functionally identical to EVP_BytesToKey, but
drops the dependency on openssl.
 2018-01-08 21:57:20 +03:00
Cory Fields
f48a300f74 crypter: hook up the new aes cbc classes 2018-01-08 21:57:12 +03:00
Cory Fields
07f4b56b4c crypter: fix the stored initialization vector size 
AES IV's are 16bytes, not 32. This was harmless but confusing.

Add WALLET_CRYPTO_IV_SIZE to make its usage explicit.
 2018-01-08 21:57:02 +03:00
Pieter Wuille
77d8ddc6fb Stop treating importaddress'ed scripts as change 
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.

Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
 2018-01-08 21:48:12 +03:00
Pedro Branco
8e2f81bb7f Prevent multiple calls to ExtractDestination 2018-01-08 21:47:33 +03:00
Jonas Schnelli
22bebdaacd [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds 2018-01-08 21:46:56 +03:00
MarcoFalke
2b9c31046b [wallet] rpc: Drop misleading option in importprunedfunds 2018-01-08 21:45:39 +03:00
instagibbs
8bca020397 Added companion removeprunedfunds call. 2018-01-08 21:36:30 +03:00
instagibbs
c37ac7db87 Add importprunedfunds rpc call 2018-01-08 21:36:08 +03:00
Patrick Strateman
db3b5d964a Move BackupWallet to CWallet::BackupWallet 2018-01-08 21:31:59 +03:00
lateminer
261efcf69a Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into wallet-updates-0.13 2018-01-08 19:45:45 +03:00
janko33bd
26cbe6bc72 Merge pull request #16 from lateminer/wallet-mod 
[Wallet] refactor wallet/init interaction
 2018-01-07 21:02:54 +01:00
lateminer
af7f906c74 Remove unused constants 2018-01-07 15:52:28 +03:00
lateminer
b808896d4c [Wallet] refactor wallet/init interaction 
25340b7cd5
 2018-01-07 15:29:36 +03:00
Jonas Schnelli
aefae306e5 [Wallet] Bugfix: FRT: don't terminate when keypool is empty 2018-01-07 13:45:21 +03:00
Gregory Maxwell
c1a0128033 Make RelayWalletTransaction attempt to AcceptToMemoryPool. 2018-01-07 13:44:47 +03:00
crowning-
40ebee8dec CDB: fix debug output 
It doesn't really help to clear a variable before printing it to the debug log.
 2018-01-07 13:38:33 +03:00
Jonas Schnelli
ea219cd59d [Wallet] Trivial cleanup of HD wallet changes 2018-01-07 13:37:11 +03:00
Wladimir J. van der Laan
77ea5eb519 wallet: Revert input selection post-pruning 
This reverts PR #4906, "Coinselection prunes extraneous inputs from
ApproximateBestSubset".

Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.

See also #7664, #7657, as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
 2018-01-07 13:36:04 +03:00
Patrick Strateman
e94e583f48 Improve CWallet API with new GetAccountPubkey function. 
Remove one more caller that is passing CWalletDB.
 2018-01-07 13:33:46 +03:00
Patrick Strateman
acf8c3d9ce Improve CWallet API with new AccountMove function. 2018-01-07 13:33:24 +03:00
Pieter Wuille
f9d2d353ff Always require OS randomness when generating secret keys 2018-01-07 13:27:51 +03:00
Patrick Strateman
ee0b4321ff Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance 2018-01-07 13:22:45 +03:00
João Barbosa
26f8d58b92 Fix lockunspents help message 2018-01-07 13:16:18 +03:00
João Barbosa
395af2c291 Prevent multiple calls to CWallet::AvailableCoins 2018-01-07 13:15:46 +03:00
Alex Morcos
db8b7554fd Don't resend wallet txs that aren't in our own mempool 2018-01-07 13:11:12 +03:00
Wladimir J. van der Laan
289e2f80b4 wallet: Warn on unexpected EOF while salvaging wallet 
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.

Stricter error checking could shed more light on issues such as #7463
and #7379.
 2018-01-07 12:57:13 +03:00
Chris Moore
412c8b9946 Reduce inefficiency of GetAccountAddress() 
Don't scan the wallet to see if the current key has been used if we're going to make a new key anyway.
Stop scanning the wallet as soon as we see that the current key has been used.
Don't call isValid() twice on the current key.
 2018-01-07 12:56:47 +03:00
lateminer
99238ff2c8 Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into rpc-updates-0.13 2018-01-06 16:41:28 +03:00
Jonas Schnelli
5deab0d5fa [Wallet] Bugfix: FRT: don't terminate when keypool is empty 
Github-Pull: #9295
Rebased-From: c24a4f5981d47d55aa9e4eb40294832a4d38fb80
 2018-01-06 15:33:50 +03:00
matthias
106dc385ee Change all instance of 'GMT epoch' to 'Unix epoch' 2018-01-06 15:04:03 +03:00
MarcoFalke
9067422492 [rpc] fundrawtransaction feeRate: Use BTC/kB 
Also introduce UniValueType

UniValueType is a wrapper for UniValue::VType which allows setting
a typeAny flag. This flag indicates the type does not matter.

(Used by RPCTypeCheckObj)
 2018-01-06 14:41:03 +03:00
MarcoFalke
ac8653f486 [rpc] fundrawtransaction: Fix help text and interface 2018-01-06 14:40:55 +03:00
Jonas Schnelli
3674e65b54 Add more clear interface for CoinControl.h regarding individual feerate 2018-01-06 14:37:42 +03:00
Jonas Schnelli
4aab709412 [RPC] add feerate option to fundrawtransaction 2018-01-06 14:37:33 +03:00
João Barbosa
fe292ef786 Add lockUnspents option to fundrawtransaction 2018-01-06 14:09:45 +03:00
João Barbosa
0e8da90b0a Add change options to fundrawtransaction 2018-01-06 14:09:13 +03:00
Wladimir J. van der Laan
b460adbab0 rpc: Register calls where they are defined 2018-01-06 13:58:48 +03:00
lateminer
36888feaff Fix: List solvability in listunspent output and improve help 2018-01-06 03:21:24 +03:00
Daniel Cousens
780775d5bd move rpc* to rpc/ 2018-01-06 01:57:48 +03:00
Jonas Schnelli
6bab17dc2d [RPC, Wallet] Move RPC dispatch table registration to wallet/ code 2018-01-06 01:27:37 +03:00
MarcoFalke
6df97ea819 [rpcwallet] Don't use floating point 2018-01-06 01:10:19 +03:00
Pieter Wuille
c23ecc1256 List solvability in listunspent output and improve help 2018-01-06 01:02:21 +03:00
Denis Lukianov
e5199580b6 Correct importaddress help reference to importpubkey 2018-01-06 00:24:35 +03:00
Wladimir J. van der Laan
106eaff884 build: Get rid of CLIENT_DATE 
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.

Continues #7732 which did this for the GUI.
 2018-01-05 23:17:08 +03:00
João Barbosa
c16a6022d1 Use CCoinControl selection in CWallet::FundTransaction 2018-01-04 20:57:46 +03:00
Jonas Schnelli
540fc749d9 [Qt] add HD enabled/disabled icon to the status bar 
914154f0cc
 2018-01-02 20:39:17 +03:00