Warren Togami
0281678d6e
doc: Fedora build requirements
2016-05-04 11:56:45 -07:00
Wladimir J. van der Laan
8206835cc1
Merge #7974 : More comments on the design of AttemptToEvictConnection.
...
d90351f More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)
2016-05-04 15:52:13 +02:00
Wladimir J. van der Laan
fc23fee690
Merge #7975 : [doc] Update bitcoin-core GitHub links
...
faf3d11 [doc] Update bitcoin-core GitHub links (MarcoFalke)
2016-05-04 14:28:38 +02:00
Wladimir J. van der Laan
08d7b563e9
util: switch LogPrint and error to variadic templates
2016-05-04 14:21:04 +02:00
fanquake
47eda2d882
[depends] Add -stdlib=libc++ to darwin CXX flags
2016-05-04 19:03:59 +08:00
Pieter Wuille
e3a9ce9c94
Refactor script tests
...
Github-Pull: #7818
Rebased-From: c7c664191f 269281b7cc d03e46625a 76da761351 009b503792 dde46d3ae1
2016-05-04 13:01:59 +02:00
Wladimir J. van der Laan
87129b24e1
test: script_error checking in script_invalid tests
...
Github-Pull: #7517
Rebased-From: b0ff8572ae 2317ad7c56 0ecb3401fe
2016-05-04 13:01:55 +02:00
Wladimir J. van der Laan
9eaa0afa6e
tinyformat: force USE_VARIADIC_TEMPLATES
...
Now that we started using c++11, force use of variadic templates.
The autodetection may be wonky on some compilers, see discussion
[here](https://github.com/bitcoin/bitcoin/pull/7982#issuecomment-216222357 )
and is unnecessary for us anyhow.
2016-05-04 11:37:10 +02:00
Wladimir J. van der Laan
559fbae8c6
Merge #7982 : build: No need to check for leveldb atomics
...
de98290 build: No need to check for leveldb atomics (Cory Fields)
2016-05-04 11:34:42 +02:00
Wladimir J. van der Laan
da46f9fd66
Merge #7989 : bitcoin-cli.cpp: Use symbolic constant for exit code
...
9a8a7d0 bitcoin-cli.cpp: Use symbolic constant for exit code (Puru)
2016-05-04 11:33:53 +02:00
MarcoFalke
88b77c7da0
Merge #7980 : [qa] smartfees: Properly use ordered dict
...
43bbcd0 [qa] Fix typos in doc and comments (Pavel Janík)
fa17f93 [qa] smartfees: Properly use ordered dict (MarcoFalke)
2016-05-03 13:13:25 +02:00
Pavel Janík
43bbcd0753
[qa] Fix typos in doc and comments
2016-05-02 22:31:00 +02:00
MarcoFalke
fa17f93fbd
[qa] smartfees: Properly use ordered dict
2016-05-02 19:36:06 +02:00
Puru
9a8a7d0115
bitcoin-cli.cpp: Use symbolic constant for exit code
2016-05-02 22:33:04 +05:45
Wladimir J. van der Laan
03cf6e8675
Merge #7959 : fix race that could fail to persist a ban
...
f4ac02e fix race that could fail to persist a ban (Kaz Wesley)
2016-05-02 14:48:50 +02:00
Wladimir J. van der Laan
86b800c6a2
Merge #7964 : Minor changes for c++11 consistency
...
07e4edb auto_ptr → unique_ptr (Wladimir J. van der Laan)
073225c chain: define enum used as bit field as uint32_t (Wladimir J. van der Laan)
2016-05-02 13:08:02 +02:00
Cory Fields
de98290155
build: No need to check for leveldb atomics
...
They're guaranteed with c++11
2016-04-30 17:46:35 -04:00
21E14
c8b92486c4
Remove obsolete reference to CValidationState from UpdateCoins.
2016-04-30 15:14:22 -04:00
Daniel Kraft
f7c4f79f07
[trivial] Add missing const qualifiers.
...
Add some const qualifiers to references that are not modified and should
be marked as const.
2016-04-30 19:25:00 +02:00
Gregory Maxwell
d90351f050
More comments on the design of AttemptToEvictConnection.
...
Some developers clearly don't get this and have been posting
"improvements" that create clear vulnerabilities. It should
have been better explained in the code, since the design
is somewhat subtle and getting it right is important.
2016-04-29 23:15:23 +00:00
MarcoFalke
faf3d11ad7
[doc] Update bitcoin-core GitHub links
2016-04-29 23:07:06 +02:00
MarcoFalke
0ad1041904
Merge #7807 : Fixed miner test values, gave constants for less error-prone values.
...
f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)
2016-04-29 22:02:59 +02:00
Jonas Schnelli
3b35e4896b
[RPC] add feerate option to fundrawtransaction
2016-04-28 22:04:07 +02:00
Andrew Chow
7db0ecb90c
Test for signing messages
...
New rpc test for signing and verifying messages.
2016-04-28 14:58:14 -04:00
Wladimir J. van der Laan
20f9ecd343
Merge #7962 : CalculateNextWorkRequired Cleanup
...
c7aac2d Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459 . (21E14)
2016-04-28 15:33:28 +02:00
Pieter Wuille
1953c40aa9
More efficient bitsliced rolling Bloom filter
...
This patch changes the implementation from one that stores 16 2-bit integers
in one uint32_t's, to one that stores the first bit of 64 2-bit integers in
one uint64_t and the second bit in another. This allows for 450x faster
refreshing and 2.2x faster average speed.
2016-04-28 14:56:32 +02:00
Pieter Wuille
aa62b68745
Benchmark rolling bloom filter
2016-04-28 14:56:32 +02:00
Wladimir J. van der Laan
5725807402
Merge #7926 : [RPC] push back getaddednodeinfo dead value
...
9c0bcb6 push back getaddednodeinfo dead value (instagibbs)
2016-04-28 14:35:40 +02:00
Wladimir J. van der Laan
a9c8b744e8
Merge #7952 : Log invalid block hash to make debugging easier.
...
61c0170 Log invalid block hash to make debugging easier. (Pavel Janík)
2016-04-28 13:53:01 +02:00
Wladimir J. van der Laan
07e4edb056
auto_ptr → unique_ptr
...
Change the few occurrences of the deprecated `auto_ptr` to c++11 `unique_ptr`.
Silences the deprecation warnings.
Also add a missing `std::` for consistency.
2016-04-28 13:43:32 +02:00
Wladimir J. van der Laan
073225cb01
chain: define enum used as bit field as uint32_t
...
Bitwise logic combined with `<` with undefined signedness will
potentially results in undefined behavior. Fix this by defining the type
as a c++11 typed enum.
Fixes #6017 .
2016-04-28 13:35:16 +02:00
Wladimir J. van der Laan
d9594bfe0c
Merge #7514 : Fix IsInitialBlockDownload for testnet
...
8aa7226 Fix IsInitialBlockDownload to play nice with testnet (jmacwhyte)
2016-04-28 12:55:35 +02:00
Wladimir J. van der Laan
574ddc63d6
Merge #7939 : qt: Make it possible to show details for multiple transactions
...
f135e3c qt: Add transaction hash to details window title (Wladimir J. van der Laan)
17a6a21 qt: Make it possible to show details for multiple transactions (Wladimir J. van der Laan)
2016-04-28 12:21:29 +02:00
Wladimir J. van der Laan
06162f19d7
Merge #7165 : build: Enable C++11 in build, require C++11 compiler
...
7df9224 doc: Add note about new build/test requirements to release notes (Wladimir J. van der Laan)
2aacc72 build: update ax_cxx_compile_stdcxx to serial 4 (Wladimir J. van der Laan)
a398549 depends: use c++11 (Cory Fields)
67969af build: Enable C++11 build, require C++11 compiler (Wladimir J. van der Laan)
2016-04-28 10:51:49 +02:00
Wladimir J. van der Laan
7df92242a9
doc: Add note about new build/test requirements to release notes
...
[skip ci]
2016-04-28 10:47:41 +02:00
Wladimir J. van der Laan
2aacc72727
build: update ax_cxx_compile_stdcxx to serial 4
2016-04-28 10:18:06 +02:00
21E14
c7aac2d557
Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459 .
2016-04-27 22:36:45 -04:00
Suhas Daftuar
43c14acf14
Fix headers announcements edge case
...
Previously we would assert that if every block in vBlockHashesToAnnounce is in
chainActive, then the blocks to be announced must connect. However, there are
edge cases where this assumption could be violated (eg using invalidateblock /
reconsiderblock), so just check for this case and revert to inv-announcement
instead.
Github-Pull: #7919
Rebased-From: 3a99fb2cb1
2016-04-27 22:34:48 +02:00
Alexander Regueiro
06c73a1751
Removed call to TryCreateDirectory from GetDefaultDataDir in src/util.cpp.
...
See https://github.com/bitcoin/bitcoin/issues/7845#issuecomment-207684728 .
Also refactored `GetDefaultDataDir` function to return path for Mac in one expression.
Github-Pull: #7850
Rebased-From: 41dbc4849e
2016-04-27 22:34:48 +02:00
Suhas Daftuar
7e71785c40
Use txid as key in mapAlreadyAskedFor
...
Previously we used the CInv that would be sent to the peer announcing the
transaction as the key, but using the txid instead allows us to decouple the
p2p layer from the application logic (which relies on this map to avoid
duplicate tx requests).
Github-Pull: #7862
Rebased-From: 7e91f632c7
2016-04-27 22:34:48 +02:00
BtcDrak
5583a3d0a7
Add curl to Gitian setup instrustions
...
curl is required to fetch dependencies
Github-Pull: #7658
Rebased-From: ce41cf082c
2016-04-27 22:34:48 +02:00
R E Broadley
d3ead9bcb6
Avoid "Unknown command" messages when receiving getaddr on outbound connections.
...
Github-Pull: #7642
Rebased-From: d84ea1a59ce3704457a162f1fd8a7353047156de
2016-04-27 22:34:48 +02:00
Patrick Strateman
a5bc6a1bc4
Remove vfReachable and modify IsReachable to only use vfLimited.
...
We do not know that a class of Network is reachable, only that it is not.
Github-Pull: #7553
Rebased-From: 110b62f069
2016-04-27 22:34:48 +02:00
Matthew Zipkin
52c101158f
Clarify description of blockindex
...
see issues:
https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237
https://github.com/bitcoin/bitcoin/issues/7532
Github-Pull: #7541
Rebased-From: 7eef1d0dad
2016-04-27 22:34:48 +02:00
Alex Morcos
21b2f82eb7
Don't resend wallet txs that aren't in our own mempool
...
Github-Pull: #7521
Rebased-From: 5a2b1c0c8b
2016-04-27 22:34:48 +02:00
Wladimir J. van der Laan
66d5408559
Fix memleak in TorController [rework]
...
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().
Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).
Replaces the fix by Jonas Schnelli in #7610 , see discussion there.
Github-Pull: #7637
Rebased-From: e219503711
2016-04-27 22:34:48 +02:00
Chris Moore
1c3d38bde7
Remove spurious dollar sign. Fixes #7189 .
...
Github-Pull: #7189
Rebased-From: 3d19193f14
2016-04-27 22:34:48 +02:00
jloughry
64fd0ce1d9
fix spelling of advertise in src and doc
...
Github-Pull: #7526
Rebased-From: 37767fd46f
2016-04-27 22:34:48 +02:00
instagibbs
a9e73f71d4
Fix and cleanup listreceivedbyX documentation
...
Github-Pull: #7527
Rebased-From: c372572595
2016-04-27 22:34:48 +02:00
ptschip
90955940d5
Do not download transactions during inital sync
...
Github-Pull: #7164
Rebased-From: 39a525c21f
2016-04-27 22:34:47 +02:00