Commit Graph

6988 Commits

Author SHA1 Message Date
janko33bd
714d2650b5 added SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS 2018-01-10 23:13:59 +01:00
janko33bd
602f3d2aad removing confusing tooltip 2018-01-10 23:06:58 +01:00
lateminer
72fb9f5567 Fix typo
wallet.cpp
2018-01-10 22:12:18 +03:00
lateminer
72875a2116 Relay double-spends, subject to anti-DOS
cef3711500 (diff-7ec3c68a81efff79b6ca22ac1f1eabbaL929)
2018-01-10 21:52:38 +03:00
janko33bd
48feed03ef Merge pull request #19 from lateminer/ui-respendalert
UI to alert of respend attempt affecting wallet.
2018-01-09 21:34:03 +01:00
lateminer
c3bddf47b2 UI to alert of respend attempt affecting wallet.
ba478d229b
2018-01-09 23:25:37 +03:00
lateminer
070424672b Add -respendnotify option, new RPC data, reg tests
f2a6c79aa1 (diff-b4d9f378d56095dfaad2a3802d633a39)
2018-01-09 22:41:38 +03:00
lateminer
765380cf35 Revert "Make RelayWalletTransaction attempt to AcceptToMemoryPool."
This reverts commit c1a0128033.
2018-01-08 22:35:33 +03:00
lateminer
e8ad469c2c Remove unnecessary code 2018-01-08 22:25:00 +03:00
Cory Fields
b06d926965 build: Enumerate ctaes rather than globbing 2018-01-08 22:04:30 +03:00
Cory Fields
aa0181e44e crypter: shuffle Makefile so that crypto can be used by the wallet 2018-01-08 22:04:21 +03:00
Cory Fields
d4b0ab2149 crypter: constify encrypt/decrypt
This makes CCrypter easier to pass aroundf for tests
2018-01-08 21:59:36 +03:00
Cory Fields
b1913e4dd2 crypter: add tests for crypter 2018-01-08 21:59:28 +03:00
Cory Fields
df2b01b7cd crypter: add a BytesToKey clone to replace the use of openssl
BytesToKeySHA512AES should be functionally identical to EVP_BytesToKey, but
drops the dependency on openssl.
2018-01-08 21:57:20 +03:00
Cory Fields
f48a300f74 crypter: hook up the new aes cbc classes 2018-01-08 21:57:12 +03:00
Cory Fields
07f4b56b4c crypter: fix the stored initialization vector size
AES IV's are 16bytes, not 32. This was harmless but confusing.

Add WALLET_CRYPTO_IV_SIZE to make its usage explicit.
2018-01-08 21:57:02 +03:00
Cory Fields
cb9ed6bc39 crypto: add aes cbc tests 2018-01-08 21:56:54 +03:00
Cory Fields
200954d962 crypto: add AES 128/256 CBC classes
The output should always match openssl's, even for failed operations. Even for
a decrypt with broken padding, the output is always deterministic (and attemtps
to be constant-time).
2018-01-08 21:56:46 +03:00
Pieter Wuille
46910cb2d5 Add ctaes-based constant time AES implementation 2018-01-08 21:56:36 +03:00
lateminer
5f9e181833 Added ctaes 2018-01-08 21:55:56 +03:00
Pieter Wuille
77d8ddc6fb Stop treating importaddress'ed scripts as change
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.

Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
2018-01-08 21:48:12 +03:00
Pedro Branco
8e2f81bb7f Prevent multiple calls to ExtractDestination 2018-01-08 21:47:33 +03:00
Jonas Schnelli
22bebdaacd [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds 2018-01-08 21:46:56 +03:00
MarcoFalke
2b9c31046b [wallet] rpc: Drop misleading option in importprunedfunds 2018-01-08 21:45:39 +03:00
instagibbs
8bca020397 Added companion removeprunedfunds call. 2018-01-08 21:36:30 +03:00
instagibbs
c37ac7db87 Add importprunedfunds rpc call 2018-01-08 21:36:08 +03:00
Patrick Strateman
db3b5d964a Move BackupWallet to CWallet::BackupWallet 2018-01-08 21:31:59 +03:00
lateminer
261efcf69a Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into wallet-updates-0.13 2018-01-08 19:45:45 +03:00
janko33bd
26cbe6bc72 Merge pull request #16 from lateminer/wallet-mod
[Wallet] refactor wallet/init interaction
2018-01-07 21:02:54 +01:00
janko33bd
518e327e7c Merge pull request #14 from lateminer/rpc-updates-0.13
RPC updates from Bitcoin Core 0.13.x
2018-01-07 21:02:38 +01:00
lateminer
af7f906c74 Remove unused constants 2018-01-07 15:52:28 +03:00
lateminer
b808896d4c [Wallet] refactor wallet/init interaction
25340b7cd5
2018-01-07 15:29:36 +03:00
Jonas Schnelli
aefae306e5 [Wallet] Bugfix: FRT: don't terminate when keypool is empty 2018-01-07 13:45:21 +03:00
Gregory Maxwell
c1a0128033 Make RelayWalletTransaction attempt to AcceptToMemoryPool. 2018-01-07 13:44:47 +03:00
crowning-
40ebee8dec CDB: fix debug output
It doesn't really help to clear a variable before printing it to the debug log.
2018-01-07 13:38:33 +03:00
Jonas Schnelli
ea219cd59d [Wallet] Trivial cleanup of HD wallet changes 2018-01-07 13:37:11 +03:00
Wladimir J. van der Laan
77ea5eb519 wallet: Revert input selection post-pruning
This reverts PR #4906, "Coinselection prunes extraneous inputs from
ApproximateBestSubset".

Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.

See also #7664, #7657, as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
2018-01-07 13:36:04 +03:00
Patrick Strateman
e94e583f48 Improve CWallet API with new GetAccountPubkey function.
Remove one more caller that is passing CWalletDB.
2018-01-07 13:33:46 +03:00
Patrick Strateman
acf8c3d9ce Improve CWallet API with new AccountMove function. 2018-01-07 13:33:24 +03:00
Pieter Wuille
4db9e14749 Don't use assert for catching randomness failures 2018-01-07 13:28:01 +03:00
Pieter Wuille
f9d2d353ff Always require OS randomness when generating secret keys 2018-01-07 13:27:51 +03:00
Patrick Strateman
ee0b4321ff Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance 2018-01-07 13:22:45 +03:00
João Barbosa
26f8d58b92 Fix lockunspents help message 2018-01-07 13:16:18 +03:00
João Barbosa
395af2c291 Prevent multiple calls to CWallet::AvailableCoins 2018-01-07 13:15:46 +03:00
Alex Morcos
db8b7554fd Don't resend wallet txs that aren't in our own mempool 2018-01-07 13:11:12 +03:00
Wladimir J. van der Laan
289e2f80b4 wallet: Warn on unexpected EOF while salvaging wallet
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.

Stricter error checking could shed more light on issues such as #7463
and #7379.
2018-01-07 12:57:13 +03:00
Chris Moore
412c8b9946 Reduce inefficiency of GetAccountAddress()
Don't scan the wallet to see if the current key has been used if we're going to make a new key anyway.
Stop scanning the wallet as soon as we see that the current key has been used.
Don't call isValid() twice on the current key.
2018-01-07 12:56:47 +03:00
Thomas Snider
3b0604b58d [ui] Add toggle for unblinding password fields 2018-01-07 01:18:20 +03:00
lateminer
b4b34ff770 Get rid of remaining auto_ptr mentions 2018-01-06 16:44:09 +03:00
lateminer
99238ff2c8 Merge remote-tracking branch 'janko33bd/Blackcoin-Lore' into rpc-updates-0.13 2018-01-06 16:41:28 +03:00