UI to alert of respend attempt affecting wallet.
Respend transactions that conflict with transactions already in the wallet are added to it. They are not displayed unless they also involve the wallet, or get into a block. If they do not involve the wallet, they continue not to affect balance. Transactions that involve the wallet, and have conflicting non-equivalent transactions, are highlighted in red. When the conflict first occurs, a modal dialog is thrown. CWallet::SyncMetaData is changed to sync only to equivalent transactions. When a conflict is added to the wallet, counter nConflictsReceived is incremented. This acts like a change in active block height for the purpose of triggering UI updates.
This commit is contained in:
15
src/wallet.h
15
src/wallet.h
@@ -141,6 +141,9 @@ public:
|
||||
MasterKeyMap mapMasterKeys;
|
||||
unsigned int nMasterKeyMaxID;
|
||||
|
||||
// Increment to cause UI refresh, similar to new block
|
||||
int64_t nConflictsReceived;
|
||||
|
||||
CWallet()
|
||||
{
|
||||
SetNull();
|
||||
@@ -163,6 +166,7 @@ public:
|
||||
nNextResend = 0;
|
||||
nLastResend = 0;
|
||||
nTimeFirstKey = 0;
|
||||
nConflictsReceived = 0;
|
||||
}
|
||||
|
||||
std::map<uint256, CWalletTx> mapWallet;
|
||||
@@ -305,6 +309,13 @@ public:
|
||||
{
|
||||
return (GetDebit(tx) > 0);
|
||||
}
|
||||
bool IsConflicting(const CTransaction& tx) const
|
||||
{
|
||||
BOOST_FOREACH(const CTxIn& txin, tx.vin)
|
||||
if (mapTxSpends.count(txin.prevout))
|
||||
return true;
|
||||
return false;
|
||||
}
|
||||
int64_t GetDebit(const CTransaction& tx) const
|
||||
{
|
||||
int64_t nDebit = 0;
|
||||
@@ -377,7 +388,7 @@ public:
|
||||
int GetVersion() { LOCK(cs_wallet); return nWalletVersion; }
|
||||
|
||||
// Get wallet transactions that conflict with given transaction (spend same outputs)
|
||||
std::set<uint256> GetConflicts(const uint256& txid) const;
|
||||
std::set<uint256> GetConflicts(const uint256& txid, bool includeEquivalent) const;
|
||||
|
||||
/** Address book entry changed.
|
||||
* @note called with lock cs_wallet held.
|
||||
@@ -699,7 +710,7 @@ public:
|
||||
|
||||
void RelayWalletTransaction();
|
||||
|
||||
std::set<uint256> GetConflicts() const;
|
||||
std::set<uint256> GetConflicts(bool includeEquivalent=true) const;
|
||||
};
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user