From 83b546163ba0150804574309247210b93e63c463 Mon Sep 17 00:00:00 2001 From: Michel van Kessel Date: Mon, 28 Dec 2020 17:28:05 +0100 Subject: [PATCH] replace boost_foreach --- src/bitcoin-cli.cpp | 30 ++++++------- src/bitcoin-tx.cpp | 42 +++++++++--------- src/bitcoind.cpp | 27 ++++++------ src/httpserver.cpp | 1 - src/keystore.cpp | 2 - src/main.cpp | 2 +- src/memusage.h | 1 - src/miner.cpp | 66 ++++++++++++++++------------- src/miner.h | 10 ++++- src/policy/fees.cpp | 24 +++++------ src/policy/fees.h | 4 +- src/policy/policy.cpp | 48 ++++++++++----------- src/policy/policy.h | 6 +-- src/qt/addressbookpage.cpp | 29 ++++++++----- src/qt/addresstablemodel.cpp | 2 - src/qt/bitcoingui.cpp | 65 ++++++++++++++++------------ src/qt/clientmodel.cpp | 26 ++++++------ src/qt/clientmodel.h | 7 ++- src/qt/coincontroldialog.cpp | 36 ++++++++-------- src/qt/coincontroldialog.h | 2 +- src/qt/optionsdialog.cpp | 37 +++++++++------- src/qt/optionsmodel.cpp | 30 ++++++------- src/qt/optionsmodel.h | 4 +- src/qt/paymentserver.cpp | 50 +++++++++++----------- src/qt/peertablemodel.cpp | 16 +++---- src/qt/peertablemodel.h | 4 +- src/qt/platformstyle.cpp | 6 +-- src/qt/receivecoinsdialog.cpp | 26 ++++++------ src/qt/receivecoinsdialog.h | 4 +- src/qt/recentrequeststablemodel.cpp | 18 ++++---- src/qt/recentrequeststablemodel.h | 5 +-- src/qt/sendcoinsdialog.cpp | 65 +++++++++++++++------------- src/qt/sendcoinsdialog.h | 4 +- src/qt/walletmodeltransaction.cpp | 2 +- src/test/DoS_tests.cpp | 1 - src/test/base58_tests.cpp | 1 - src/test/bip32_tests.cpp | 2 +- src/test/coins_tests.cpp | 2 +- src/test/getarg_tests.cpp | 3 +- src/test/miner_tests.cpp | 2 +- src/test/multisig_tests.cpp | 4 +- src/test/prevector_tests.cpp | 16 ++++--- src/test/script_tests.cpp | 5 +-- src/test/sigopcount_tests.cpp | 1 - src/test/test_bitcoin.cpp | 2 +- src/test/transaction_tests.cpp | 2 +- src/wallet/rpcwallet.cpp | 12 +++--- 47 files changed, 394 insertions(+), 360 deletions(-) diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index bf6f11a50..dab40b0cf 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -4,15 +4,15 @@ // file COPYING or http://www.opensource.org/licenses/mit-license.php. #if defined(HAVE_CONFIG_H) -#include "config/bitcoin-config.h" +#include #endif -#include "chainparamsbase.h" -#include "clientversion.h" -#include "rpc/client.h" -#include "rpc/protocol.h" -#include "util.h" -#include "utilstrencodings.h" +#include +#include +#include +#include +#include +#include #include #include @@ -82,9 +82,9 @@ static int AppInitRPC(int argc, char* argv[]) std::string strUsage = strprintf(_("%s RPC client version"), _(PACKAGE_NAME)) + " " + FormatFullVersion() + "\n"; if (!mapArgs.count("-version")) { strUsage += "\n" + _("Usage:") + "\n" + - " bitcoin-cli [options] [params] " + strprintf(_("Send command to %s"), _(PACKAGE_NAME)) + "\n" + - " bitcoin-cli [options] help " + _("List commands") + "\n" + - " bitcoin-cli [options] help " + _("Get help for a command") + "\n"; + " blackmore-cli [options] [params] " + strprintf(_("Send command to %s"), _(PACKAGE_NAME)) + "\n" + + " blackmore-cli [options] help " + _("List commands") + "\n" + + " blackmore-cli [options] help " + _("Get help for a command") + "\n"; strUsage += "\n" + HelpMessageCli(); } @@ -133,8 +133,8 @@ static void http_request_done(struct evhttp_request *req, void *ctx) { HTTPReply *reply = static_cast(ctx); - if (req == NULL) { - /* If req is NULL, it means an error occurred while connecting, but + if (req == nullptr) { + /* If req is nullptr, it means an error occurred while connecting, but * I'm not sure how to find out which one. We also don't really care. */ reply->status = 0; @@ -165,14 +165,14 @@ UniValue CallRPC(const string& strMethod, const UniValue& params) throw runtime_error("cannot create event_base"); // Synchronously look up hostname - struct evhttp_connection *evcon = evhttp_connection_base_new(base, NULL, host.c_str(), port); // TODO RAII - if (evcon == NULL) + struct evhttp_connection *evcon = evhttp_connection_base_new(base, nullptr, host.c_str(), port); // TODO RAII + if (evcon == nullptr) throw runtime_error("create connection failed"); evhttp_connection_set_timeout(evcon, GetArg("-rpcclienttimeout", DEFAULT_HTTP_CLIENT_TIMEOUT)); HTTPReply response; struct evhttp_request *req = evhttp_request_new(http_request_done, (void*)&response); // TODO RAII - if (req == NULL) + if (req == nullptr) throw runtime_error("create http request failed"); // Get credentials diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index dad4cf5bc..cd47c11ac 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -3,25 +3,25 @@ // file COPYING or http://www.opensource.org/licenses/mit-license.php. #if defined(HAVE_CONFIG_H) -#include "config/bitcoin-config.h" +#include #endif -#include "base58.h" -#include "chainparams.h" -#include "clientversion.h" -#include "coins.h" -#include "consensus/consensus.h" -#include "core_io.h" -#include "dstencode.h" -#include "keystore.h" -#include "policy/policy.h" -#include "primitives/transaction.h" -#include "script/script.h" -#include "script/sign.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include