Fix exit codes:

- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with `1`

Slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)

Github-Pull: #9067
Rebased-From: bd0de1386e1c7f9b875d52290de0d561c8d56bc9
This commit is contained in:
UdjinM6
2016-11-02 21:59:09 +03:00
committed by lateminer
parent 793b8f55b1
commit 10ea8235a8
4 changed files with 37 additions and 17 deletions

View File

@@ -579,7 +579,7 @@ int main(int argc, char *argv[])
{
HelpMessageDialog help(NULL, mapArgs.count("-version"));
help.showOrPrint();
return 1;
return 0;
}
/// 5. Now that settings and translations are available, ask user for data directory
@@ -600,7 +600,7 @@ int main(int argc, char *argv[])
} catch (const std::exception& e) {
QMessageBox::critical(0, QObject::tr(PACKAGE_NAME),
QObject::tr("Error: Cannot parse configuration file: %1. Only use key=value syntax.").arg(e.what()));
return false;
return 1;
}
/// 7. Determine network (and switch to network specific options)